add SmartOS support #294
add SmartOS support #294
Conversation
aqw
force-pushed
the
master
branch
3 times, most recently
from
68702af to
cd1f4e4
Compare
|
Pushed fix for linting and removal of trailing The Fedora failure is unclear to me. Perhaps spurious? |
|
I did a force push (no changes) to kick off CI again. Indeed, the Fedora failure was spurious. All tests pass. |
|
Hey @aqw the Fedora tests are unrelated, you can ignore them. I'll check out your PR! |
|
Pushed to add SmartOS to |
|
A friendly ping. Just let me know if anything needs to be reworked. :-) |
|
Sorry, I haven't had a chance to look at this yet. |
|
No worries. :-) Re tests: It looks like you're using Travis to spin up Docker instances. SmartOS descends from Solaris, and Travis itself has no direct support for it. I think this will have to be like the *BSD platforms and remain untested. :-/ |
|
On further consideration I'll merge the whole PR if you can fix the conflicts. :) |
|
I'll take a look at this today. |
Signed-off-by: Alex Waite <[email protected]>
Signed-off-by: Alex Waite <[email protected]>
Signed-off-by: Alex Waite <[email protected]>
|
The patches have been refreshed. |
|
Thank you! |
In addition to a new SmartOS.yml var file, this PR makes configurable the location of sshd (
sshd_path) and ssh host keys (ssh_host_keys_dir).The introduction of
ssh_host_keys_diris not strictly necessary, as the user can specifyssh_host_key_files. For that reason, I split it into its own commit, so you can cherry-pick around it if you so choose. However, I felt adding it was preferable, as it will work out-of-the-box, and doesn't require the user to keepssh_host_key_filesandssh_host_key_algorithmsin sync.Neither of these were added to the README, as it seems to focus on user-visible variables, which neither of these are.